Skip to content

Conversation

@sgrekhov
Copy link
Contributor

@sgrekhov sgrekhov commented Dec 1, 2025

No description provided.

@sgrekhov sgrekhov requested a review from eernstg December 1, 2025 16:06
Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, with a couple of typos.

@sgrekhov
Copy link
Contributor Author

sgrekhov commented Dec 2, 2025

Thank you! Fixed.

@sgrekhov sgrekhov requested a review from eernstg December 2, 2025 09:01
@sgrekhov
Copy link
Contributor Author

sgrekhov commented Dec 4, 2025

@eernstg PTAL

Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eernstg eernstg merged commit a4f8892 into dart-lang:master Dec 4, 2025
1 of 2 checks passed
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Dec 5, 2025
2025-12-04 sgrekhov22@gmail.com dart-lang/co19#3182. Update `augmenting_functions_A02_*.dart` test (dart-lang/co19#3426)
2025-12-04 sgrekhov22@gmail.com dart-lang/co19#3182. Add more tests for augmenting functions (dart-lang/co19#3431)
2025-12-03 sgrekhov22@gmail.com dart-lang/co19#3182. Update `augmenting_functions_A05-07*` test (dart-lang/co19#3430)
2025-12-03 sgrekhov22@gmail.com dart-lang/co19#3182. Update `augmenting_functions_A04_*.dart` test (dart-lang/co19#3429)
2025-12-02 sgrekhov22@gmail.com dart-lang/co19#3182. Delete tests that checks `augmented()` expression (dart-lang/co19#3428)
2025-12-01 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 5.0.0 to 6.0.0 in the github-actions group (dart-lang/co19#3427)
2025-12-01 sgrekhov22@gmail.com dart-lang/co19#3182. Update `augmenting_functions_A01_*.dart` test (dart-lang/co19#3425)
2025-12-01 sgrekhov22@gmail.com dart-lang/co19#3182. Fix syntax errors in enums (dart-lang/co19#3424)
2025-11-28 sgrekhov22@gmail.com dart-lang/co19#3182. Update `augmenting_enum_values_*` test (dart-lang/co19#3423)
2025-11-28 sgrekhov22@gmail.com dart-lang/co19#3182. Update augmenting_constructors_A19-20* tests (dart-lang/co19#3418)
2025-11-28 sgrekhov22@gmail.com dart-lang/co19#3182. Add tests for constructors with initializing formals (dart-lang/co19#3421)
2025-11-28 sgrekhov22@gmail.com dart-lang/co19#3182. Rename some augmenting constructors tests (dart-lang/co19#3422)

R=athom@google.com, eernst@google.com

Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try,dart2js-minified-linux-d8-try
Change-Id: I3f3ea2184eb96b3a4beb5021e4a8b08ef1f7ad37
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/466300
Auto-Submit: Sergey Grekhov <sgrekhov22@gmail.com>
Reviewed-by: Erik Ernst <eernst@google.com>
Commit-Queue: Erik Ernst <eernst@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants